fix:Moirai inference in foundation-time-series-arena#389
Open
gorold wants to merge 1 commit intoNixtla:mainfrom
Open
fix:Moirai inference in foundation-time-series-arena#389gorold wants to merge 1 commit intoNixtla:mainfrom
gorold wants to merge 1 commit intoNixtla:mainfrom
Conversation
Member
|
Hi @gorold, thank you for taking the time to run the benchmarks and improve Morai. It's great to see the increase in speed and performance. You probably saw that the Chronos also opened a PR suggesting some changes. |
Contributor
|
Hi @AzulGarza and @mergenthaler , Thanks for taking the time to look into this PR. May we ask if there are any updates? Have you verified the performance as we provided? Are we good to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for evaluating Moirai. There are some issues with the way inference is being done for Moirai:
This PR fixes these issues, and below contain the updated results. The results for the fix was run on an A100-40G GPU, but the appropriate batch size can be updated when running on your hardware.
We note a significant improvement in accuracy across all metrics, as well as inference time.